Fix custom query hotkey settings issue #3354
Conversation
prlabeler
bot
added
bug
This comment has been minimized.
This comment has been minimized.
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughThe pull request updates the hotkey handling in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Flow.Launcher/HotkeyControl.xaml.cs (2)
145-145: Error message has grammatical error.The error message "Hotkey type not setted" contains a grammatical error. The correct form would be "Hotkey type not set" or "Hotkey type not specified".
- _ => throw new System.NotImplementedException("Hotkey type not setted") + _ => throw new System.NotImplementedException("Hotkey type not set")
200-200: Same grammatical error in setter's error message.The error message "Hotkey type not setted" contains the same grammatical error as in the getter. The correct form would be "Hotkey type not set" or "Hotkey type not specified".
- throw new System.NotImplementedException("Hotkey type not setted"); + throw new System.NotImplementedException("Hotkey type not set");
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Flow.Launcher/HotkeyControl.xaml.cs(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
- GitHub Check: gitStream.cm
🔇 Additional comments (4)
Flow.Launcher/HotkeyControl.xaml.cs (4)
87-87: Good change to default TypeProperty value.Changing the default initialization from
HotkeyType.HotkeytoHotkeyType.Nonealigns with the new enum value and properly supports custom hotkeys from dialog results.
98-99: Appropriate addition ofNoneenum value.Adding the
Noneenum value with a descriptive comment clarifies its purpose for getting hotkeys from dialog results. This addition is necessary for handling custom hotkeys that aren't part of the settings.
121-121: Good implementation for custom hotkey storage.The addition of the private
hotkeyfield and its usage in the getter whenTypeisHotkeyType.Noneproperly separates custom hotkeys from settings-based hotkeys.Also applies to: 128-130
152-156: Good implementation for custom hotkey assignment.The addition of the
HotkeyType.Nonecase in the setter properly handles custom hotkeys by storing the value in the privatehotkeyfield.
This comment has been minimized.
This comment has been minimized.
|
do you mind briefly introduce what's the issue? |
As you can see, the new version of And previously, the default value of |
|
Now I added new |
jjw24
added
Dev branch only
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
|
🥷 Code experts: Yusyuriv, onesounds Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
3 participants
Add new
enumtype to handle logic for custom query hotkey setting dialogAs you can see, the new version of
HotkeyControlusesTypeto specific theHotkeygetter and setter.And previously, the default value of
TypeisHotkeyso theHotkeyControlinCustomQueryHotkeySettingswill fallback tocase HotkeyType.Hotkey:, resulting the change of the search hotkey.So we need to add a new
enumtype so thatHotkeyControlwill cache the hotkey value and return it as result which is needed forCustomQueryHotkeySettings(it uses )Follow on with #3310.
Test